docs: add LICENSE (MIT)#116
Conversation
|
On it, @rubenhensen! I'm reviewing PR #116 now and will check the LICENSE file addition for correctness and rule-compliance before submitting a consolidated review. |
![dobby-coder[bot]](https://avatars.githubusercontent.com/in/3365457?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — approving. ✅
What this does: adds a top-level LICENSE (MIT, Copyright 2021 Encryption 4 All) copied verbatim from encryption4all/postguard, and sets "license": "MIT" in package.json. Resolves the ambiguous default-copyright state (closes #108).
Verification:
LICENSEis byte-identical toencryption4all/postguard's main LICENSE — confirms the "copied verbatim" claim and keeps the two repos consistent.package.jsonparses as valid JSON with aMITlicense field.- All 14 CI checks pass, including the
Conventional Commit/pr-title.ymlgate — the titledocs: add LICENSE (MIT)is valid conventional-commit format. - Per-rule compliance sweep across all repo + org rules: no violations. (
private: truealongside an MIT license is fine — a license field on a private package is valid.)
Tests were not run separately — this is a doc/metadata-only change with no runtime behavior to exercise.
Non-blocking nit (follow-up, out of scope for this PR): README.md has no ## License section, which the org standardized-README format expects. Now that the repo has a license, a short ## License (MIT) section in the README would be a nice consistency follow-up.
FYI on the copyright line: the 2021 year and Encryption 4 All holder were carried over verbatim from postguard for consistency. If postguard-business post-dates 2021 you may want to bump the year, but matching the parent repo is a reasonable call — no change required.
|
Reviewed and approved! ✅ All 14 CI checks pass, the LICENSE is byte-identical to the main postguard repo, and the conventional commit title looks good. One non-blocking note: it'd be nice to add a section to the README at some point, but that's a follow-up — nothing blocking merge here. |
|
Thanks @dobby-coder — added the |
1 participant
Closes #108.
Adds a
LICENSEfile — the repo had none, so default copyright applied and usage/contribution rights were ambiguous.Choice
Matches the main encryption4all/postguard repo: MIT, copied verbatim (including the
Copyright 2021 Encryption 4 Allline) so the two stay consistent. Also sets"license": "MIT"inpackage.json.Say the word if you'd rather bump the copyright year or holder text.